-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor native debugger #4581
Comments
Android and linux must be splitted in its own OS. also any unix compatible shared code can be copied and pasted multiple times. |
Hey @wargio can you share a bit more about what file(s) are supposed to be changed ? |
That is correct. The issue is that the debugger is full of bugs and quite unreliable because one change in an arch, breaks another arch. |
Ok thank you very much for the quick response. Can I start working on this issue ? |
No need to ask for permission, go for it |
Hello @wargio I am almost done with refactoring the code. Can you tell me how should I test my changes ? I have used |
Just open a PR and see what you break. Be sure your branch name starts with |
i would not close this since the last point is not done. |
Currently the native debugger implemented in Rizin is a mess of
#ifdef
which always brings bugs each time is touched.The idea behind this refactoring is to split all the native archs into files and just fill a structure with function pointers for each feature that the native debugger code needs.
This allows to cleanup the code and fix all weird behaviors in each OS.
The text was updated successfully, but these errors were encountered: