From 8d4a1a0d4fc92036eb37bff9a5b7aed0d78d8b40 Mon Sep 17 00:00:00 2001 From: luigi-rosso Date: Tue, 23 Apr 2024 03:50:40 +0000 Subject: [PATCH] Fix audio instances Fixes issue reported here: https://2dimensions.slack.com/archives/CSFM8K3CH/p1713795412798999 Part of the problem here was that the audio clips were never getting their "end" callback called as miniaudio doesn't call the "end" callback when an end time is provided that is not the end of the actual audio file. I modified the AudioEngine to create an appropriately sized PCM buffer for buffered sources and wrap the decoder in an audio source that only decodes the necessary PCM frames before marking the file is actually at its end (based on desired end frame). This is the cleanest way to make miniaudio call the callback without modifying the miniaudio source itself. Diffs= 2b2e92ca7 Fix audio instances (#7113) --- .rive_head | 2 +- .rive_renderer | 2 +- submodules/rive-cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.rive_head b/.rive_head index 6218e1ba..a5698263 100644 --- a/.rive_head +++ b/.rive_head @@ -1 +1 @@ -14ea38786d50c49c23753ff9f5df349c012fb298 +2b2e92ca7ef815c7c60176c14bed4bd488d44d0c diff --git a/.rive_renderer b/.rive_renderer index bc2505fe..cfe26237 100644 --- a/.rive_renderer +++ b/.rive_renderer @@ -1 +1 @@ -938f5040166c949ae45d991b837b46eab3137ead +5ba7d6b3a4bde15fef4c8d4beba0368d63d15ac4 diff --git a/submodules/rive-cpp b/submodules/rive-cpp index 6276d838..2f5f3f21 160000 --- a/submodules/rive-cpp +++ b/submodules/rive-cpp @@ -1 +1 @@ -Subproject commit 6276d83854045d0c26d65521037e82e3c01cf5e7 +Subproject commit 2f5f3f21ca789dbffa4d2967350e599f997935a7