Changes needed to get rive-bevy working with bevy 0.13.0 and vello 0.1.0 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the bare minimum needed to get
rive-bevyworking withbevy 0.13.0andvello 0.1.0, which will fix #17For this to work, you need the changes to
rive-rsin this pr: rive-app/rive-rs#6There are probably a lot of improvements to be made by folks who know this space better than I -- I was just trying to knock together something that would allow me to evaluate Rive for my bevy project.
Would love some help from the Rive experts to tune this up a bit, but hopefully this is a helpful start -- clearing out the chore bits so that you experts can focus on the fine tuning!
Also: everything compiles, but I have not tested all of the examples at this point. I know at least some of them crash intermittently. Again, hoping this is a helpful start even if it's not totally ready...