Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it doesn't work with new version of jquery-ui #79

Open
ZPVIP opened this issue Jan 12, 2017 · 6 comments
Open

it doesn't work with new version of jquery-ui #79

ZPVIP opened this issue Jan 12, 2017 · 6 comments

Comments

@ZPVIP
Copy link

ZPVIP commented Jan 12, 2017

it's works great with old version of jquery-ui

jquery-rails (4.1.1)
jquery-ui-rails (5.0.5)
//= require jquery-ui/autocomplete

but not with new version, for example it doesn't highlight the selected option

jquery-rails (4.2.2)
jquery-ui-rails (6.0.1)
//= require jquery-ui/widgets/autocomplete
@phianh42
Copy link

I may be running into version issues too. I have an app where this gem works fine, with jquery v2.1.4, and a newer app with jquery v3.1.1 where the gem is not working at all. Anyone having it, too?
I'm also struggling to get the newer app to use an earlier version of jquery, despite specifying version of jquery-rails in Gemfile.

@phianh42
Copy link

Update: finally got the gem to work by downgrading to jquery v2.1.4 with:

//= require jquery2
(instead of //= require jquery)

But it'd be nice to be able to use the gem with jquery v3+.

@vitormd
Copy link

vitormd commented Apr 28, 2017

I actually can't downgrade to jquery2 and I am trying to upgrade my app to Rails 5.
This is the only gem that is breaking the project tests.

Just for the record, this is the error stack:

One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).

      TypeError: undefined is not an object (evaluating 't.split')
      TypeError: undefined is not an object (evaluating 't.split')
          at http://127.0.0.1:57647/assets/autocomplete-rails.self-7b9f3d470095312074f7dba7e53e16482b6ac8c4c5fe8dd368f321fd8324245c.js?body=1:1 in a
          at http://127.0.0.1:57647/assets/autocomplete-rails.self-7b9f3d470095312074f7dba7e53e16482b6ac8c4c5fe8dd368f321fd8324245c.js?body=1:1 in i
          at http://127.0.0.1:57647/assets/autocomplete-rails.self-7b9f3d470095312074f7dba7e53e16482b6ac8c4c5fe8dd368f321fd8324245c.js?body=1:1 in search
          at http://127.0.0.1:57647/assets/jquery-ui/widget.self-c1602241ddc51216b58391768667068867b8e15b9efc722befcd25771eda6819.js?body=1:516 in _trigger
          at http://127.0.0.1:57647/assets/jquery-ui/autocomplete.self-3befc48aba87cead090cfd014562b2771a662ac6d2c8197b24c08b2d9f3d9f2d.js?body=1:428 in search
          at http://127.0.0.1:57647/assets/jquery-ui/widget.self-c1602241ddc51216b58391768667068867b8e15b9efc722befcd25771eda6819.js?body=1:116
          at http://127.0.0.1:57647/assets/jquery-ui/autocomplete.self-3befc48aba87cead090cfd014562b2771a662ac6d2c8197b24c08b2d9f3d9f2d.js?body=1:413
          at http://127.0.0.1:57647/assets/jquery-ui/widget.self-c1602241ddc51216b58391768667068867b8e15b9efc722befcd25771eda6819.js?body=1:461 in handlerProxy
          at :0 in sendEvent
          at phantomjs://code/web_page.js:59
          at phantomjs://code/web_page.js:558 in mouseEvent
          at phantomjs://code/node.js:67 in mouseEvent
          at phantomjs://code/browser.js:398 in mouse_event
          at phantomjs://code/browser.js:418 in click
          at phantomjs://code/browser.js:89 in runCommand
          at phantomjs://code/cmd.js:35 in run
          at phantomjs://code/main.js:18 in runCommand
          at phantomjs://code/connection.js:16 in commandReceived
          at phantomjs://code/connection.js:1 (Capybara::Poltergeist::JavascriptError)

EDIT: Not sure if mostly phantomjs or rails-jquery-autcomplete fault, but this is the gem that breaks phantomjs though

@bhgames
Copy link

bhgames commented Nov 2, 2017

Following the above changes, and downgrading AA to 1.0.0.pre1 worked for me, to have it on ActiveAdmin in a 4.2.6 app.

@adiakritos
Copy link

I've had the same issue.

If you create a barebones app and set it up using the tutorial info - the only thing that breaks it is switching the jQuery version to 3.

How can this be fixed? What exactly is breaking when it uses jQuery 3?

@rioug
Copy link

rioug commented Jun 20, 2018

The master works with jQuery 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants