Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The CI doesn't trigger the Clippy action #67

Open
dyxushuai opened this issue Dec 12, 2023 · 2 comments
Open

The CI doesn't trigger the Clippy action #67

dyxushuai opened this issue Dec 12, 2023 · 2 comments

Comments

@dyxushuai
Copy link
Contributor

dyxushuai commented Dec 12, 2023

Independent issue for tracking the CI problem. The original discussion: #64 (review)

My opinion: #64 (comment)

I think it doesn't add Clippy component in the risc0/risc0/.github/actions/rustup action.
Perhaps we can add the snippet:

with:
	components: clippy
  clippy:
    name: clippy
    runs-on: ubuntu-latest
    timeout-minutes: 30
    steps:
    - uses: actions/checkout@v3
      with:
        submodules: recursive
    - uses: risc0/risc0/.github/actions/[email protected]
      with:
        components: clippy
    - uses: risc0/risc0/.github/actions/[email protected]
    - uses: risc0/clippy-action@main
      with:
        reporter: 'github-pr-check'
        fail_on_error: true
        github_token: ${{ secrets.GITHUB_TOKEN }}
        clippy_flags: --workspace --all-targets --all-features -- -Dwarnings
@Wollac
Copy link
Contributor

Wollac commented Dec 12, 2023

In general, the CI triggers reviewdog [clippy] (e.g. https://github.com/risc0/zeth/runs/19521165223). However, it seems to depend on the module 🤔
Maybe it is related to the fact that clippy does not work from the command line...

@dyxushuai
Copy link
Contributor Author

In general, the the CI triggers reviewdog [clippy] (e.g. risc0/zeth/runs/19521165223). However, it seems to depend on the module 🤔 Maybe it is related to the fact that clippy does not work from the command line...

I got lots of context from you. I want to give the issue a try in the coming days.

johntaiko pushed a commit to johntaiko/zeth that referenced this issue Apr 10, 2024
Move blob decoding to the guest as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants