Codespaces support for v4 #1635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarquessV
reviewed
Sep 11, 2023
| - .:/home/rigetti/pyquil/ | ||
| environment: | ||
| - QCS_SETTINGS_APPLICATIONS_PYQUIL_QVM_URL=http://qvm:5000 | ||
| - QCS_SETTINGS_APPLICATIONS_PYQUIL_QUILC_URL=tcp://quilc:5555 |
There was a problem hiding this comment.
These environment variables should be QCS_APPLICATIONS_QVM_URL QCS_APPLICATIONS_QUILC_URL
There was a problem hiding this comment.
Good point. Will update since targeting v4
| ENV PATH="$VIRTUAL_ENV/bin:$PATH" | ||
|
|
||
| WORKDIR ${APP_DIR} | ||
| ENV SHELL /bin/bash |
There was a problem hiding this comment.
This dockerfile is used for the Forest SDK Docker image. Is there any way we can provide a different dockerfile for codespaces?
There was a problem hiding this comment.
Yeah, we could do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for VSCode devcontainer and GitHub Codespaces. Dockerfile is rewritten, docker-compose.yaml is added and the .devcontainer folder is added.