Skip to content
This repository has been archived by the owner on Jun 6, 2021. It is now read-only.

Feature/bulk sending #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature/bulk sending #44

wants to merge 4 commits into from

Conversation

rjmunro
Copy link
Contributor

@rjmunro rjmunro commented Aug 14, 2013

Begin work on bulk sending of push messages. Not ready for merging yet, just posting for comment purposes.

Depends on: #36 being merged first.

* Adds a handler
*
* @param $osType
* @param $service
*/
public function addHandler($osType, $service)
public function addHandler(string $osType, OS\OSNotificationServiceInterface $service)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't typehint for string

queue() queues messages without calling sendMessages(), so you can
then call sendMessages manually.

Refactored send to call queue() then sendMessages().

Tidied code a little to conform to PSR-2
@ghost
Copy link

ghost commented Nov 18, 2013

I think this is a quite important feature actually. How can we accelerate the work on this?

@richsage
Copy link
Owner

@rjmunro are you able to look at this again?

@abbood
Copy link

abbood commented Jul 8, 2014

can't this just be done by combining this library with a delayed job kinda library like BCCResqueBundle?

@rjmunro
Copy link
Contributor Author

rjmunro commented Jul 8, 2014

@abbood The push message providers offer nice bulk sending capabilities, but we are not using them. Adding a queue library would not help with this.

@guidolodetti
Copy link

Does this bundle work with multiple messages? I'm viewing the source code but really, I can't understand!


$handler = $this->handlers[$message->getTargetOS()];

if (method_exists($handler, "queue")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be nice to create a BulkNotificationInterface instead of doing this ?

@muffe
Copy link

muffe commented Jan 23, 2015

@rjmunro Whats the status of this?

@ruscon
Copy link

ruscon commented May 14, 2015

ping ?

@romeugodoi
Copy link

@rjmunro How is this issue? tks.

@rjmunro
Copy link
Contributor Author

rjmunro commented Nov 3, 2017

I'm not able to do any more work on this. If someone wants to take it over, please do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants