Update project_and_code_guidelines.md #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have static images in the drawable folder. We should give the name with prefix img_ for all images.
jemmaSlater
requested changes
Nov 28, 2017
There was a problem hiding this comment.
Thanks for opening a pull request!
I am happy to merge the 'img_' prefix, but think it probably belongs in the table above showing types of drawables, rather than the table for icons. If you could move it to the drawables table, in alphabetical order, I will then merge. Thanks!
| @@ -41,6 +41,7 @@ Naming conventions for icons (taken from [Android iconography guidelines](http:/ | |||
| | Status bar icons | `ic_stat_notify` | `ic_stat_notify_msg.png` | | |||
| | Tab icons | `ic_tab` | `ic_tab_recent.png` | | |||
| | Dialog icons | `ic_dialog` | `ic_dialog_info.png` | | |||
| | Images | `img_` | `img_walkthourgh_one.png` | | |||
There was a problem hiding this comment.
typo in spelling of 'walkthrough' :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have static images in the drawable folders. We should give the name with prefix img_ for all images.