Fix number order in the 2.2 section. #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey thanks for this amazing guide! The 2.2.2 has been skipped.
jemmaSlater
requested changes
Nov 28, 2017
There was a problem hiding this comment.
Hello! There were some numbers missing in this section, not sure how that happened - thanks for fixing it and opening a pull request.
There are just a couple now which are out of place still which I have identified below, if you wouldn't mind adjusting them I will merge it. Thanks!
| @@ -449,7 +449,7 @@ There are two __exceptions__ where it is possible to have lines longer than 100: | |||
| * Lines that are not possible to split, e.g. long URLs in comments. | |||
| * `package` and `import` statements. | |||
|
|
|||
| #### 2.2.15.1 Line-wrapping strategies | |||
| #### 2.2.14.1 Line-wrapping strategies | |||
| @@ -501,7 +501,7 @@ loadPicture(context, | |||
| "Title of the picture"); | |||
| ``` | |||
|
|
|||
| ### 2.2.16 RxJava chains styling | |||
| ### 2.2.15 RxJava chains styling | |||
ed-george
added a commit
to ed-george/android-guidelines
that referenced
this pull request
Feb 19, 2019
Fixes ribot#31 - number issues within 2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey thanks for this amazing guide! The 2.2.2 has been skipped.