cmake: Allow to build with system libraries and other improvements #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option will enable fetching and building of dependencies. The default is OFF to use system libraries instead.
If you import the project (Add_ExternalProject) CMAKE_SOURCE_DIR is pointing to a different directory.
This way other cmake project can find the library using: find_package(piper_phonemize)
|
This is good and very useful! Please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset allows you to build piper-phonemize with system libraries instead of fetching sources from the internet. For this a new option has been introduced BUILD_EXTERNAL which will enable building with external sources. The default in cmake is OFF in the Makefile it is ON.
This also generates a cmake config file so you can consume the library using
find_package(piper_phonemize)from other cmake files. It also fixes some issues if you use it as an external project.You can see it building for openSUSE against system libraries here:
https://build.opensuse.org/package/show/home:gladiac/piper-phonemize