Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeModulesConfig status management functions #710

Conversation

qbarrand
Copy link
Member

Use the plural form for the NodeModulesConfig CRD, per convention.
Add new CRD fields to be used by the NodeModulesConfig reconciler.

/cc @yevgeny-shnaidman @ybettan

Use the plural form for the NodeModulesConfig CRD, per convention.
Add new CRD fields to be used by the NodeModulesConfig reconciler.

Upstream-Commit: 1767d02
@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit a759238
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/64e5f58c789d1f0009f12c62
😎 Deploy Preview https://deploy-preview-710--openshift-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yevgeny-shnaidman
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4565f26 into rh-ecosystem-edge:main Aug 23, 2023
6 checks passed
@qbarrand qbarrand deleted the cp-1767d02cf6724f663a350c879d0f9c993ef8f6c9 branch August 23, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants