Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation #672

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

qbarrand
Copy link
Member

Document that the OpenShift internal container image registry is not enabled by default on bare metal installation.
Replace Fedora kernel versions with RHEL.

Fixes #370

@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit b9c7a03
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/64c0d185f7d2c100089b134a
😎 Deploy Preview https://deploy-preview-672--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@qbarrand
Copy link
Member Author

/cc @iranzo

@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2023

@qbarrand: GitHub didn't allow me to request PR reviews from the following users: iranzo.

Note that only rh-ecosystem-edge members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @iranzo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qbarrand
Copy link
Member Author

/hold

Document that the OpenShift internal container image registry is not
enabled by default on bare metal installation.
Replace Fedora kernel versions with RHEL.
@qbarrand
Copy link
Member Author

/unhold

@yevgeny-shnaidman
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5874baa into rh-ecosystem-edge:main Jul 26, 2023
6 checks passed
@qbarrand qbarrand deleted the issue-370 branch July 27, 2023 07:10
yevgeny-shnaidman added a commit to yevgeny-shnaidman/kernel-module-management that referenced this pull request Dec 20, 2023
…-ecosystem-edge#672)

since "ready" labels are public APIs of KMM, operators using KMM
may want to schedule they workloads based on the presence of those
labels.
yevgeny-shnaidman added a commit to yevgeny-shnaidman/kernel-module-management that referenced this pull request Dec 20, 2023
…-ecosystem-edge#672)

since "ready" labels are public APIs of KMM, operators using KMM
may want to schedule they workloads based on the presence of those
labels.
openshift-merge-bot bot pushed a commit that referenced this pull request Dec 20, 2023
…) (#937)

since "ready" labels are public APIs of KMM, operators using KMM
may want to schedule they workloads based on the presence of those
labels.
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/kernel-module-management that referenced this pull request Dec 20, 2023
…-ecosystem-edge#672)

since "ready" labels are public APIs of KMM, operators using KMM
may want to schedule they workloads based on the presence of those
labels.
openshift-merge-bot bot pushed a commit that referenced this pull request Dec 20, 2023
…) (#938)

since "ready" labels are public APIs of KMM, operators using KMM
may want to schedule they workloads based on the presence of those
labels.

Co-authored-by: Yevgeny Shnaidman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Document that internal registry is not enabled by default on BM installations
3 participants