Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TomerNewman to OWNERS file #1165

Conversation

TomerNewman
Copy link
Member

@TomerNewman TomerNewman commented Jul 22, 2024

Adding user TomerNewman and removing qbarrand from the OWNERS file, with approvers and reviewers privileges.

Copy link

openshift-ci bot commented Jul 22, 2024

Hi @TomerNewman. Thanks for your PR.

I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit 3f7e4c9
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/669e5f94e1c24e0008f1d34e
😎 Deploy Preview https://deploy-preview-1165--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yevgeny-shnaidman
Copy link
Member

/ok-to-test
/lgtm
/approve

Copy link

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomerNewman, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bthurber
Copy link
Collaborator

Please remove Quentin from the owners.

@ybettan
Copy link
Collaborator

ybettan commented Jul 22, 2024

/hold
Can you please keep the alphabetical order?

Adding TomerNewman and removing qbarrand from OWNERS file, with 'approvers' and 'reviewers' privileges
@ybettan
Copy link
Collaborator

ybettan commented Jul 22, 2024

/unhold
/lgtm

@TomerNewman
Copy link
Member Author

/verify-owners

@openshift-merge-bot openshift-merge-bot bot merged commit 3ba2656 into rh-ecosystem-edge:main Jul 23, 2024
19 checks passed
@TomerNewman TomerNewman deleted the add-tomernewman-to-owners branch August 27, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants