Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Creator] Add Ability To Fetch All Media And Sort Reversed [CC-1916] #54

Conversation

zeph-cohen10
Copy link

@zeph-cohen10 zeph-cohen10 commented Oct 10, 2024

CC-1916

This PR adds a new YPConfig property: shouldPreselectRecentsAlbum which when true will display all media in a similar way the "Recents" album does in Photos. Essentially this takes all of the media from all smart albums and sorts them in inverse order so that the most recently added content appears on the top of the list instead of sorting the media by creationDate as the current implementation does.

This functionality will be behind a new feature flag on the client that toggles this YPConfig property.

A couple of details on the flows touched:

  • The initial load of the image picker which shows all media sorted in inverse order
  • Opening the albums picker and manually selecting "Recents" album persists this ordering.
  • Selecting any smart album that is not "Recents" or any other user created album does not apply this ordering, and instead applies the default ordering.
  • When this YPConfig option is disabled then the regular ordering by creationDate is used.

@zeph-cohen10 zeph-cohen10 self-assigned this Oct 10, 2024
@zeph-cohen10 zeph-cohen10 marked this pull request as ready for review October 11, 2024 14:21
@sigsbeym sigsbeym merged commit fc55a2d into master Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants