feat: add deleteEmoji method to Server class #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix issue #86 by adding the deleteEmoji method to the Server class. I went with the usual pattern used for deleting. I also tried to make the code style fit into Server.ts's already existing style of code.
insertish
approved these changes
Jun 8, 2024
|
Okay I'm a bit tired, I didn't notice this has no association with Server, it makes more sense for this to be defined on Emoji class as a static method but this works too. |
insertish
changed the title
insertish
pushed a commit
that referenced
this pull request
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #86 by adding the deleteEmoji method to the Server class. I went with the usual pattern used for deleting. I also tried to make the code style fit into Server.ts's already existing style of code.
Please make sure to check the following tasks before opening and submitting a PR