Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint panic on Go 1.18 doesn't fail check #249

Open
derekperkins opened this issue Mar 24, 2022 · 1 comment
Open

golangci-lint panic on Go 1.18 doesn't fail check #249

derekperkins opened this issue Mar 24, 2022 · 1 comment

Comments

@derekperkins
Copy link

There are known issues in golangci-lint around 1.18 compatibility, listed below. The real issue is that this action reports success even when the underlying code fails.

Related Issues

Config

      - name: golangci-lint
        uses: reviewdog/action-golangci-lint@master
        with:
          tool_name: golangci-lint
          golangci_lint_version: v1.44.0
          reviewdog_version: v0.13.1
          go_version: '1.18.0'
          # we're not having reviewdog cache for us because we're caching across multiple actions here
          cache: false
          level: error
          fail_on_error: true
          reporter: github-pr-review
          filter_mode: diff_context

Error Output

Running golangci-lint with reviewdog 🐶 ...
  /home/runner/work/_temp/reviewdog-gvywRD/golangci-lint-1.44.0-nz1-linux-amd64/golangci-lint run --out-format line-number
  panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
  
  goroutine 1 [running]:
  github.com/go-critic/go-critic/checkers.init.22()
  	/home/dlaird/go/pkg/mod/github.com/go-critic/[email protected]/checkers/embedded_rules.go:46 +0x4b4
  /home/runner/work/_temp/reviewdog-gvywRD/reviewdog -f=golangci-lint -name=golangci-lint -reporter=github-pr-review -filter-mode=diff_context -fail-on-error=true -level=error

image

copart-jafloyd pushed a commit to cognifloyd/vela-worker that referenced this issue Apr 21, 2022
it was installing 1.18 which can panic or have a variety of silent failures.
See: reviewdog/action-golangci-lint#249
@oliver-anz
Copy link

Is there any progress or a known workaround for this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants