From 34ddcea273cd3b228f9662048eecf17d98716bfa Mon Sep 17 00:00:00 2001 From: Michael Eischer Date: Sat, 11 Nov 2023 20:12:10 +0100 Subject: [PATCH 1/2] CI: Update golangci-lint and github actions --- .github/workflows/linters.yml | 8 ++++---- .github/workflows/tests.yml | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml index 86f1632..17a1b84 100644 --- a/.github/workflows/linters.yml +++ b/.github/workflows/linters.yml @@ -9,7 +9,7 @@ on: pull_request: env: - latest_go: "1.19.x" + latest_go: "1.21.x" jobs: lint: @@ -17,18 +17,18 @@ jobs: runs-on: ubuntu-latest steps: - name: Set up Go ${{ env.latest_go }} - uses: actions/setup-go@v3 + uses: actions/setup-go@v4 with: go-version: ${{ env.latest_go }} - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: golangci-lint uses: golangci/golangci-lint-action@v3 with: # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version. - version: v1.49 + version: v1.55 args: --verbose --timeout 5m - name: Check go.mod/go.sum diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 292791b..90bc663 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -13,19 +13,19 @@ jobs: strategy: matrix: include: - - go: 1.19.x + - go: 1.21.x - go: 1.12.x name: Build Go ${{ matrix.go }} runs-on: ubuntu-latest steps: - name: Set up Go ${{ matrix.go }} - uses: actions/setup-go@v3 + uses: actions/setup-go@v4 with: go-version: ${{ matrix.go }} - name: Check out code - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Build run: | From 4a624e820328ef79a1fa75d2afffd8745c6966a9 Mon Sep 17 00:00:00 2001 From: Michael Eischer Date: Sat, 11 Nov 2023 20:16:22 +0100 Subject: [PATCH 2/2] remove unused parameter --- main.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/main.go b/main.go index a872912..b8e6fbf 100644 --- a/main.go +++ b/main.go @@ -399,7 +399,7 @@ func githubIDs(urls []*url.URL, e *Entry) { } } -func readEntries(dir string, versions []Release) (entries map[string][]Entry) { +func readEntries(versions []Release) (entries map[string][]Entry) { entries = make(map[string][]Entry) for _, ver := range versions { @@ -500,7 +500,7 @@ func main() { } } - all := readEntries(opts.InputDir, releases) + all := readEntries(releases) for _, ver := range releases { if len(all[ver.Version]) == 0 { continue