Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update components and cleanup unnecesssary settings for the tracing-example. #175

Closed
wants to merge 1 commit into from
Closed

Update components and cleanup unnecesssary settings for the tracing-example. #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 2 additions & 28 deletions tracing-example/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
<version.org.jboss.resteasy.extensions>2.0.1.Final</version.org.jboss.resteasy.extensions>
<version.org.junit>5.10.1</version.org.junit>
<version.org.wildfly.arquillian>5.0.1.Final</version.org.wildfly.arquillian>
<version.wildfly-maven-plugin>4.2.1.Final</version.wildfly-maven-plugin>
<version.org.wildfly>28.0.0.Beta1</version.org.wildfly>
<version.wildfly-maven-plugin>5.0.0.Alpha2</version.wildfly-maven-plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to decide how I feel about using an Alpha release in an example. Examples should be able to be modified to use in production. However, by adding a Alpha dependency makes it not feel like production quality.

That said, this is a plugin version so maybe it doesn't matter as much. It might though :)

<version.org.wildfly>30.0.0.Final</version.org.wildfly>
<dep.tracing.scope>provided</dep.tracing.scope>
<!-- Test properties -->
<jboss.home>${project.build.directory}${file.separator}wildfly</jboss.home>
Expand Down Expand Up @@ -145,7 +145,6 @@
<scope>test</scope>
</dependency>
</dependencies>

<build>
<finalName>${project.artifactId}</finalName>
<testResources>
Expand Down Expand Up @@ -187,13 +186,6 @@
<configuration>
<jboss-home>${jboss.home}</jboss-home>
<provisioning-dir>${jboss.home}</provisioning-dir>
<feature-packs>
<feature-pack>
<groupId>org.wildfly</groupId>
<artifactId>wildfly-ee-galleon-pack</artifactId>
<version>${version.org.wildfly}</version>
</feature-pack>
</feature-packs>
<galleon-options>
<jboss-fork-embedded>true</jboss-fork-embedded>
</galleon-options>
Expand Down Expand Up @@ -227,24 +219,6 @@
<version>${version.wildfly-maven-plugin}</version>
<configuration>
<jboss-home>${jboss.home}</jboss-home>
<!-- First configure the feature pack we are overriding -->
<feature-packs>
<feature-pack>
<groupId>org.wildfly</groupId>
<artifactId>wildfly-ee-galleon-pack</artifactId>
<version>${version.org.wildfly}</version>
<excluded-packages>
<name>product.conf</name>
<name>docs.schema</name>
</excluded-packages>
</feature-pack>
<!-- Next include our own feature pack -->
<feature-pack>
<groupId>org.jboss.resteasy</groupId>
<artifactId>galleon-feature-pack</artifactId>
<version>${version.org.jboss.resteasy}</version>
</feature-pack>
</feature-packs>
Comment on lines -230 to -247
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove this, we don't override the RESTEasy version in the container. Maybe that's not a big deal, but something to consider. TBH it's something we should think about for all the examples.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I see!

</configuration>
<executions>
<execution>
Expand Down