Update components and cleanup unnecesssary settings for the tracing-example.
#175
Conversation
tracing-example/pom.xml
Outdated
| @@ -39,7 +39,8 @@ | |||
| <version.org.junit>5.10.1</version.org.junit> | |||
| <version.org.wildfly.arquillian>5.0.1.Final</version.org.wildfly.arquillian> | |||
| <version.wildfly-maven-plugin>4.2.0.Final</version.wildfly-maven-plugin> | |||
There was a problem hiding this comment.
The version of the plugin is 5.0.0.Alpha2.
liweinan
changed the title
tracing-exampletracing-example.
|
@jfdenise It seems like this example just works without extra feature-packs settings, so it doesn't need the Glow to detect the feature packs and layers to use. I'll try to find another example that can be used as a show case. (I plan to use https://github.com/resteasy/resteasy-spring-examples which will need Glow for sure). @jamezp I changed the title of this PR. Could you please help to review it when you have time? Thanks! |
| @@ -38,8 +38,8 @@ | |||
| <version.org.jboss.resteasy.extensions>2.0.1.Final</version.org.jboss.resteasy.extensions> | |||
| <version.org.junit>5.10.1</version.org.junit> | |||
| <version.org.wildfly.arquillian>5.0.1.Final</version.org.wildfly.arquillian> | |||
| <version.wildfly-maven-plugin>4.2.1.Final</version.wildfly-maven-plugin> | |||
| <version.org.wildfly>28.0.0.Beta1</version.org.wildfly> | |||
| <version.wildfly-maven-plugin>5.0.0.Alpha2</version.wildfly-maven-plugin> | |||
There was a problem hiding this comment.
I'm trying to decide how I feel about using an Alpha release in an example. Examples should be able to be modified to use in production. However, by adding a Alpha dependency makes it not feel like production quality.
That said, this is a plugin version so maybe it doesn't matter as much. It might though :)
| <!-- First configure the feature pack we are overriding --> | ||
| <feature-packs> | ||
| <feature-pack> | ||
| <groupId>org.wildfly</groupId> | ||
| <artifactId>wildfly-ee-galleon-pack</artifactId> | ||
| <version>${version.org.wildfly}</version> | ||
| <excluded-packages> | ||
| <name>product.conf</name> | ||
| <name>docs.schema</name> | ||
| </excluded-packages> | ||
| </feature-pack> | ||
| <!-- Next include our own feature pack --> | ||
| <feature-pack> | ||
| <groupId>org.jboss.resteasy</groupId> | ||
| <artifactId>galleon-feature-pack</artifactId> | ||
| <version>${version.org.jboss.resteasy}</version> | ||
| </feature-pack> | ||
| </feature-packs> |
There was a problem hiding this comment.
If we remove this, we don't override the RESTEasy version in the container. Maybe that's not a big deal, but something to consider. TBH it's something we should think about for all the examples.
|
I'll close this PR and leave the comments for reference. Currently it seems hard to find a use case situation that needs the Glow for a |
No description provided.