Update Cloud trust policy for Lambda deployments #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcholakov
commented
Jun 13, 2024
docs/deploy/cloud.md
Outdated
Comment on lines
94
to
98
| "Condition": { | ||
| "StringEquals": { | ||
| "aws:PrincipalArn": "arn:aws:iam::654654156625:role/RestateCloud" | ||
| } | ||
| } |
There was a problem hiding this comment.
Technically we can remove this and shorten the policy to just:
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Principal": {
"AWS": "arn:aws:iam::654654156625:root"
},
"Action": "sts:AssumeRole",
"Condition": {
"StringEquals": {
"aws:PrincipalArn": "arn:aws:iam::654654156625:role/RestateCloud",
"sts:ExternalId": "${ENVIRONMENT_ID}"
}
}
},
{
"Sid": "AllowTagSession",
"Effect": "Allow",
"Principal": {
"AWS": "arn:aws:iam::654654156625:root"
},
"Action": "sts:TagSession"
}
]
}It's no less secure since the role principal is the only one that can AssumeRole - it's shorter but less pedantic :-)
Deploying documentation with
|
| Latest commit: |
9c50dac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dcae6864.documentation-beg.pages.dev |
| Branch Preview URL: | https://update-cloud-trust-policy.documentation-beg.pages.dev |
jackkleeman
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed to work with an updated version of restate-holiday which is still slightly WIP.