Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud documentation #383

Merged
merged 8 commits into from
Jun 2, 2024
Merged

Cloud documentation #383

merged 8 commits into from
Jun 2, 2024

Conversation

jackkleeman
Copy link
Contributor

Not for merging until closer to release, I guess!

@jackkleeman jackkleeman requested a review from gvdongen May 21, 2024 16:16
Copy link
Contributor

@gvdongen gvdongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Can be merged after the two comments have been fixed.

docs/deploy/cloud.md Outdated Show resolved Hide resolved
docs/deploy/cloud.md Outdated Show resolved Hide resolved
Copy link

cloudflare-workers-and-pages bot commented May 28, 2024

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: fc7ab71
Status:⚡️  Build in progress...

View logs

Copy link
Contributor

@pcholakov pcholakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great writeup! 👏 Left some minor comments, apart from theits > it's everything is subjective.

docs/deploy/cloud.md Outdated Show resolved Hide resolved
docs/deploy/cloud.md Outdated Show resolved Hide resolved
docs/deploy/cloud.md Outdated Show resolved Hide resolved
docs/deploy/cloud.md Outdated Show resolved Hide resolved
docs/operate/cli.mdx Outdated Show resolved Hide resolved
docs/deploy/cloud.md Outdated Show resolved Hide resolved
@jackkleeman jackkleeman changed the base branch from main to release_1.0 June 2, 2024 12:45
@jackkleeman jackkleeman merged commit d730ee5 into release_1.0 Jun 2, 2024
1 of 2 checks passed
@jackkleeman jackkleeman deleted the cloud branch June 2, 2024 12:46
gvdongen pushed a commit that referenced this pull request Jun 7, 2024
* Cloud documentation

* Update docs/deploy/cloud.md

Co-authored-by: Pavel Tcholakov <[email protected]>

* Update docs/deploy/cloud.md

Co-authored-by: Pavel Tcholakov <[email protected]>

* Update docs/deploy/cloud.md

Co-authored-by: Pavel Tcholakov <[email protected]>

* Update docs/operate/cli.mdx

Co-authored-by: Pavel Tcholakov <[email protected]>

* Update docs/deploy/cloud.md

Co-authored-by: Pavel Tcholakov <[email protected]>

* Unify proxy and tunnel

* Use role name

---------

Co-authored-by: Pavel Tcholakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants