Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CLI in quickstart #250

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Use CLI in quickstart #250

merged 2 commits into from
Jan 11, 2024

Conversation

gvdongen
Copy link
Contributor

@gvdongen gvdongen commented Jan 5, 2024

Fixes #246

  • Add option to use the CLI for the quickstart

@gvdongen
Copy link
Contributor Author

gvdongen commented Jan 5, 2024

Test build is failing due to broken link to /restate/cli#installation
--> Will be solved once PR #249 is merged

Comment on lines 122 to +124
Now, we need to tell Restate where the service is running.
We do this by sending a request to the endpoint of the runtime at `http://localhost:9070/deployments`

We can do this via the CLI:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested:
Now, we need to tell Restate where the service is running. To do this, we register a new "deployment" on restate server.

We can do this via the CLI:

Run the Restate Docker container:

```shell
docker run --name restate_dev --rm -d -p 8080:8080 -p 9070:9070 -p 9071:9071 docker.io/restatedev/restate:VAR::RESTATE_VERSION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can drop the docker.io part, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this didn't work for some setups. I am not sure anymore which one though. Let me check...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed re dropping it
we need 9072 here - see #254

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's required for podman apparently

@gvdongen gvdongen merged commit 57fff70 into main Jan 11, 2024
0 of 2 checks passed
@gvdongen gvdongen deleted the cli_quickstart branch January 11, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CLI in quick start
3 participants