Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service endpoint -> Deployments #229

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Service endpoint -> Deployments #229

merged 4 commits into from
Dec 20, 2023

Conversation

slinkydeveloper
Copy link
Contributor

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 15, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a34da5d
Status: ✅  Deploy successful!
Preview URL: https://cc62b002.documentation-beg.pages.dev
Branch Preview URL: https://deployments.documentation-beg.pages.dev

View logs

@slinkydeveloper slinkydeveloper mentioned this pull request Dec 18, 2023
Closed
tillrohrmann
tillrohrmann reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @slinkydeveloper. The changes look good to me. One question that came up was whether we should rather use "service deployment" instead of "deployment" alone in the documentation texts. Maybe this makes it clearer that we are talking about service deployment and not a server deployment?

docs/quickstart.mdx Outdated Show resolved Hide resolved
@slinkydeveloper
Copy link
Contributor Author

slinkydeveloper commented Dec 18, 2023 •
edited
Loading

service deployment

I think you're right on this. let me go through this pr again then.

@slinkydeveloper
Copy link
Contributor Author

slinkydeveloper commented Dec 18, 2023 •
edited
Loading

uhhhhh if we change to service_deployment, then how about the admin REST resource? should that be ServiceDeployment (or ServicesDeployment) as well? my guess would be yes.

@slinkydeveloper
Copy link
Contributor Author

I did another pass at this, sometimes using the term Service deployment

tillrohrmann
tillrohrmann approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating the PR @slinkydeveloper. +1 for merging.

docs/services/upgrades-removal.md Outdated Show resolved Hide resolved
docs/tour.mdx Outdated Show resolved Hide resolved
docs/tour.mdx Outdated Show resolved Hide resolved
@slinkydeveloper slinkydeveloper merged commit bc16e2a into main Dec 20, 2023
3 checks passed
@slinkydeveloper slinkydeveloper deleted the deployments branch December 20, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slinkydeveloper @tillrohrmann