Add shortcuts to SDKs and allow query parameters #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
5ff765d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://60544830.documentation-beg.pages.dev |
| Branch Preview URL: | https://add-shortcuts.documentation-beg.pages.dev |
pcholakov
approved these changes
Dec 15, 2023
| @@ -88,6 +88,16 @@ const config = { | |||
| target: "_self", | |||
| }, | |||
| items: [ | |||
| { | |||
| href: "/services/sdk/overview?sdk=ts", | |||
| label: "Typescript SDK", | |||
There was a problem hiding this comment.
Nitpick – we have somewhat inconsistent capitalisation of TypeScript; I believe the canonical spelling is with a capital S :-)
Suggested change
| label: "Typescript SDK", | |
| label: "TypeScript SDK", |
There was a problem hiding this comment.
Also: should we refer to this as the TypeScript / JavaScript SDK? 🤔
There was a problem hiding this comment.
Oh you're right. I'll adapt that everywhere... Maybe in a separate PR to avoid overflowing this one.
| }, | ||
| { | ||
| to: "/services/sdk/overview?sdk=java", | ||
| label: "Java SDK", |
There was a problem hiding this comment.
Ditto "Java / Kotlin SDK"?
There was a problem hiding this comment.
Added an issue for writing Kotlin docs in general: #227
We can take this approach where it's similar for both. But for example, the example on the overview page will look different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226