Describe abort/inactivity timeouts #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
e72340f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c6c58836.documentation-beg.pages.dev |
| Branch Preview URL: | https://issues-216.documentation-beg.pages.dev |
tillrohrmann
approved these changes
Dec 15, 2023
| When suspending, Restate internally holds another timer to protect Restate from connection issues and/or misbehaving code/SDKs that prevent the tear down of the connection. This timer can be configured with the option [`worker.invoker.abort_timeout`](https://docs.restate.dev/restate/configuration). | ||
| Once the `abort_timeout` is fired, the user code is potentially interrupted, and all the subsequent progress is potentially lost. | ||
|
|
||
| If you have [side effects](sdk/side-effects) that take more than `inactivity_timeout + abort_timeout` to execute, you might need to tune these timeouts accordingly, for example by increasing the `inactivity_timeout` to a value larger than the expected side effect duration. |
There was a problem hiding this comment.
I guess this not only applies to side effects but computation in general.
There was a problem hiding this comment.
I know, but I think this is easier to explain and probably much more common to happen, I don't really know how to word "computation in general" :) Any proposal?
There was a problem hiding this comment.
Maybe side effect is fine because it is something people familiar with Restate will understand as a computation step. Computation in general might be misunderstood as the whole handler must not take longer than this duration.
Co-authored-by: Till Rohrmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #216