Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour improvements #160

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Tour improvements #160

merged 5 commits into from
Oct 13, 2023

Conversation

gvdongen
Copy link
Contributor

@gvdongen gvdongen commented Oct 3, 2023

  • Make the exposed ports in docker run uniform
  • Improve explanation of service registration
  • Improve explanation of keyed services

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for docsrestatedev ready!

Name Link
🔨 Latest commit 26bd9fb
🔍 Latest deploy log https://app.netlify.com/sites/docsrestatedev/deploys/6528eb4e2f6ac800085a2b7c
😎 Deploy Preview https://deploy-preview-160--docsrestatedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@AhmedSoliman AhmedSoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comment, thanks for working on this @gvdongen

docs/tour.mdx Show resolved Hide resolved
docs/tour.mdx Outdated
Comment on lines 196 to 197
The scope of a key is on a per-service basis.
Per key there is at most one concurrent invocation at the service level, so across all functions in that service.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe more Layman's terms? like
"Function invocations of keyed services are serialized on the user-defined key. Therefore, at most one function can run at a time on a given key within such service."

I don't know if this is better, but what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

docs/tour.mdx Outdated Show resolved Hide resolved
Co-authored-by: Ahmed Farghal <[email protected]>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 26bd9fb
Status:⚡️  Build in progress...

View logs

@gvdongen gvdongen merged commit 41cb86e into main Oct 13, 2023
1 of 2 checks passed
@gvdongen gvdongen deleted the tour_improvements branch October 13, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants