-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tour improvements #160
Tour improvements #160
Conversation
gvdongen
commented
Oct 3, 2023
- Make the exposed ports in docker run uniform
- Improve explanation of service registration
- Improve explanation of keyed services
✅ Deploy Preview for docsrestatedev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comment, thanks for working on this @gvdongen
docs/tour.mdx
Outdated
The scope of a key is on a per-service basis. | ||
Per key there is at most one concurrent invocation at the service level, so across all functions in that service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe more Layman's terms? like
"Function invocations of keyed services are serialized on the user-defined key. Therefore, at most one function can run at a time on a given key within such service."
I don't know if this is better, but what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
Co-authored-by: Ahmed Farghal <[email protected]>
…on into tour_improvements