Quickstart improvements #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsrestatedev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying with
|
| Latest commit: |
f28248f
|
| Status: | ⚡️ Build in progress... |
AhmedSoliman
approved these changes
Oct 4, 2023
Comment on lines
+33
to
+36
| You can run the app with `ts-node-dev` while developing: | ||
| ```shell | ||
| npm run app-dev | ||
| ``` |
There was a problem hiding this comment.
We already run the app In step 3, right? I'm not sure if this change is needed. Maybe just leave it at npm install and let the build+run be in step 3 as the existing flow. What do you think?
There was a problem hiding this comment.
The idea was to clarify that you can run with ts-node-dev while developing your services, via npm run app-dev.
Once you are done with development, you build and run with npm run app
Merged
Co-authored-by: Ahmed Farghal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run build