Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the README to include some pointers on getting started with CDK #18

Closed
pcholakov opened this issue Dec 12, 2023 · 9 comments
Closed
Assignees

Comments

@pcholakov
Copy link
Collaborator

The information published at https://www.npmjs.com/package/@restatedev/restate-cdk is very sparse; it should contain some pointers on getting started with the CDK and probably a link to restatedev/examples#50 once merged.

@pcholakov
Copy link
Collaborator Author

PR: #20

@pcholakov
Copy link
Collaborator Author

Also added a new page to the doc website: restatedev/documentation#234

@pcholakov pcholakov self-assigned this Dec 18, 2023
@pcholakov
Copy link
Collaborator Author

Merged but won't release a new npm artifact until we have released the documentation (which is in turned blocked on releasing the runtime with the latest interface changes).

@tillrohrmann
Copy link
Contributor

Why is the CDK release blocked on the documentation release @pcholakov?

@pcholakov
Copy link
Collaborator Author

pcholakov commented Jan 2, 2024

The updated README links to the as-yet-unpublished CDK page introduced by restatedev/documentation#234 – do you think it's enough of an improvement to release even with a broken link?

Here's the CDK-with-Lambda reference page: https://10ac2971.documentation-beg.pages.dev/services/deployment/cdk

@tillrohrmann
Copy link
Contributor

tillrohrmann commented Jan 2, 2024

The broken link is not perfect but strictly speaking it already exists when looking at the README in main of this repo. Given that the README already contains a lot of helpful information compared to the is-state (released artifact), I would be fine with creating a release with a temporarily broken link.

@pcholakov pcholakov reopened this Jan 2, 2024
@pcholakov
Copy link
Collaborator Author

You are quite right! I just had a mental block against pushing out the broken link – this is still a strict improvement.

v0.4.2 release kicked off: https://github.com/restatedev/cdk/actions/runs/7388711431

@pcholakov
Copy link
Collaborator Author

@tillrohrmann
Copy link
Contributor

Much better! https://www.npmjs.com/package/@restatedev/restate-cdk

Cool :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants