Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severe bug in ResonanceAudio.setRoomProperties() #19

Closed
auriiolym opened this issue Oct 10, 2018 · 1 comment
Closed

Severe bug in ResonanceAudio.setRoomProperties() #19

auriiolym opened this issue Oct 10, 2018 · 1 comment

Comments

@auriiolym
Copy link

Since the recent Chrome 69 update, the buffer property on a ConvolverNode can't be set twice. This is used in LateReflections.setDurations(), which is used by Room.setProperties(), which is used by ResonanceAudio.setRoomProperties().

The error (accompanied by the above stacktrace):

Uncaught (in promise) DOMException: Failed to set the 'buffer' property on 'ConvolverNode': Cannot set buffer to non-null after it has been already been set to a non-null buffer

The development team has several demos listed on the 'getting started' page, which link to the demo page found here. Of those demos, the two that use ResonanceAudio.setRoomProperties() give the mentioned error. The 'Hello World' demo shows the error right after clicking 'Play', while the 'Room Models' demo shows it after playing one of the sounds and then changing the room dimensions or the wall materials (both resulting in a call to ResonanceAudio.setRoomProperties()).

@auriiolym
Copy link
Author

Oh nvm, I see it was already reported here. Still, I'd recommend giving this some priority to prevent a Firefox requirement for a fair amount of VR applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant