Increase Maximum Number Of Host Parameters In A Single SQL Statement #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this change doesn't negatively effect memory usage in a typical use case then should be able to merge it. May also be possible to configure it this way and then lower the limit at runtime and have it be configurable somehow. Will look into this! |
This was referenced Jan 22, 2020
Closed
C2H6O
added a commit
to plangrid/sqlite-android
that referenced
this pull request
Feb 14, 2020
See requery#125 for details. This PR contains code changes that are currently live in the prod artifact (see plangrid/plangrid-android#8016 where the dependency was updated from io.requery:sqlite-android to io.requery:sqlite-android-plangrid). I had to work with devops to manually upload the artifact that I created locally because developers don't have access to uploading things to artifactory. Once JENKINS is setup, it'll have access to uploading artifacts to our artifactory. Follow-ups: - Update README with PlanGrid specific notes about the changes - Setup JENKINS for Publishing - Mark https://github.com/plangrid/SQLite-FTS5-Android as deprecated - Update https://github.com/plangrid/SQLite-FTS5-Synonyms-Android to remove SQLite-FTS5 submodule, update JENKINS to no longer publish SQLite-FTS5, and remove any reference to SQLite-FTS5 from that repo
|
https://www.sqlite.org/limits.html
Since SQLite v3.35.5 got merged in last week does this mean it will use the new defaults (i.e. 32766 for SQLITE_MAX_VARIABLE_NUMBER)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #124. Is this something that can be merged into this repo, instead of us having to fork it?