Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reqnroll.Microsoft.Extensions.Logging.ReqnrollPlugin #321

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

StefH
Copy link

@StefH StefH commented Nov 8, 2024

🤔 What's changed?

As discussed here #247
I've created a new projects which cn be used to forward the logging from an ILogger to IReqnrollOutputHelper.

⚡️ What's your motivation?

#247

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

Initial code, please provide feedback.
And should this be called a "Plugin" because it does not actually implement IRuntimePlugin.

📋 Checklist:

  • I've changed the behaviour of the code
  • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Users should know about my change
  • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

@clrudolphi
Copy link
Contributor

Interesting idea. I'd like your thoughts on a related effort. We're considering adding use of Microsoft Logging internal to Reqnroll, to be used by Reqnroll maintainers and developers of Plugins, to obtain Trace and Debug-level output. This would be used to understand what's going on within the Reqnroll engine. The idea, though, is to steer such output away from the Test Framework's output stream (aka, avoid calling IReqnrollOutputHelper) so that the internal debug output doesn't interfere with the usual output of the Tests themselves.

With that description, would you think your approach for this plugin would need to be different?
How should we approach using and configuring MS Logging so that two use cases remain separated and don't intermix their log outputs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants