Fix: Reqnroll generates invalid code for rule backgrounds in Visual Basic #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajeckmans
approved these changes
Oct 7, 2024
gasparnagy
added a commit
that referenced
this pull request
Oct 7, 2024
…el-prototype * origin/main: Fix: Reqnroll generates invalid code for rule backgrounds in Visual Basic (#284)
gasparnagy
added a commit
that referenced
this pull request
Oct 14, 2024
* main: Bump version VS Code integration proper doc title (#280) Fix: Reqnroll generates invalid code for rule backgrounds in Visual Basic (#284) Update nunit.md (#276) SolutionTests: Check if SDK version is installed and if not ignore the test (#266) Fix for #271 This PR modifies the Feature AST visitor to appropriately handle Rule Background steps. (#272) Bugfix/fix reqnroll.verify parallelization (#255)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Fixes #283
The important bit is just the removal of the unnecessary
using (new SourceLineScope(_reqnrollConfiguration, _codeDomHelper, statements, context.Document.SourceFilePath, background.Location))line from theScenarioPartHelperclass, the rest is just to have a test.🏷️ What kind of change is this?
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.