Cleanup #97
Merged
Cleanup #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a struct that is attached to the transport for the dialcontext. This struct contains the resolution override map. It is now expected that commands will pass down the map as part of the Client Options.
Quick benchmark shows a 200-300MB/s increase on slower downloads (e.g. from one provider to another) when not blocking the primary execution block to make the request prior to downloading the chunk.
philandstuff
approved these changes
Dec 11, 2023
pkg/client/client.go
Outdated
Comment on lines
141
to
143
| if d.DNSOverrideMap == nil { | ||
| return d.Dialer.DialContext(ctx, network, addr) | ||
| } |
There was a problem hiding this comment.
We don't need this guard; a nil map behaves like an empty map when reading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate global host resolution map - generally less fragile avoiding a global causing behavior changes.
Make the same fix made to consistent-hashing and move the .doRequest to within the go routine preventing blocking the main thread for no good reason.