Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: ensure --resolve and -v work in multifile mode #96

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

tempusfrangit
Copy link
Member

@tempusfrangit tempusfrangit commented Dec 10, 2023

rootCMD was changed (erroneously) to use a PreRunE not a PersistentPreRunE that caused --resolve and -v to be properly handled. This meant multifile could not rely on --resolve or -v for anything useful (they were never "set" from multifile's perspective)

Closes: #95

rootCMD was changeds to have a PreRunE not a PersistentPreRunE that
caused --resolve and -v to be properly handled. This meant multifile
could not rely on --resolve or -v for anything useful (they were never
"set" from multifile's perspective)

Closes: #95
@tempusfrangit tempusfrangit merged commit 241f65a into main Dec 10, 2023
3 checks passed
@tempusfrangit tempusfrangit deleted the fix-resolve branch December 10, 2023 05:23
tempusfrangit added a commit that referenced this pull request Dec 10, 2023
rootCMD was changed (erroneously) to use a PreRunE not a PersistentPreRunE
that caused --resolve and -v to be properly handled. This meant multifile
could not rely on --resolve or -v for anything useful (they were never "set"
from multifile's perspective)

Closes: #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: --resolve is broken in versions beyond v0.1.1 [and main:HEAD]
1 participant