Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Null Consumer/Consumer updates #102

Closed
tempusfrangit opened this issue Dec 10, 2023 · 1 comment · Fixed by #167
Closed

Enhancement: Null Consumer/Consumer updates #102

tempusfrangit opened this issue Dec 10, 2023 · 1 comment · Fixed by #167
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@tempusfrangit
Copy link
Member

When null consumer is used ...

  • dest existence check should be skipped
  • if possible the second argument (multifile mode at least) in the manifest format should be optional
  • if possible the second argument in single-file mode should be optional

Perhaps the consumer is responsible for determining if a file can be overwritten?
@tempusfrangit tempusfrangit added the enhancement New feature or request label Dec 10, 2023
@tempusfrangit
Copy link
Member Author

partially addressed with #120

@tempusfrangit tempusfrangit added this to the 1.0.0 milestone Feb 15, 2024
tempusfrangit added a commit that referenced this issue Feb 20, 2024
@tempusfrangit
Improve null consumer
8fe22b4 
Do not require 2 arguments when using null consumer.

Multifile manifest still requires a target. This is to maintain continuity
in the manifest parsing code.

Closes: #102
@tempusfrangit tempusfrangit mentioned this issue Feb 20, 2024
Merged
tempusfrangit added a commit that referenced this issue Feb 20, 2024
@tempusfrangit
Improve null consumer
afcbff4 
Do not require 2 arguments when using null consumer.

Multifile manifest still requires a target. This is to maintain continuity
in the manifest parsing code.

Closes: #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Improve null consumer replicate/pget
1 participant
@tempusfrangit