Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bring back previous interface of solana rpc #675

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zoruka
Copy link
Contributor

@zoruka zoruka commented Aug 15, 2024

Description

This PR brings back the previous signature field of the Solana's signTransaction response. It also brings the deserialization of the transaction in base64 as described in our RPC specs.

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-react-ethersv5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 10:20pm
appkit-react-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 10:20pm
decentralized-relay-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 10:20pm
react-wallet-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 10:20pm
vue-web-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 10:20pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
decentralized-relay-app ⬜️ Ignored (Inspect) Aug 15, 2024 10:20pm
malicious-dapp-verify-simulation ⬜️ Ignored (Inspect) Aug 15, 2024 10:20pm
react-auth-dapp ⬜️ Ignored (Inspect) Aug 15, 2024 10:20pm
react-auth-wallet ⬜️ Ignored (Inspect) Aug 15, 2024 10:20pm
react-dapp-v2 ⬜️ Ignored (Inspect) Aug 15, 2024 10:20pm
react-dapp-v2-cosmos-provider ⬜️ Ignored (Inspect) Aug 15, 2024 10:20pm
react-dapp-v2-with-ethers ⬜️ Ignored (Inspect) Aug 15, 2024 10:20pm
react-dapp-v2-with-web3js ⬜️ Ignored (Inspect) Aug 15, 2024 10:20pm
svelte-web3modal ⬜️ Ignored (Inspect) Aug 15, 2024 10:20pm
vue-dapp-auth ⬜️ Ignored (Inspect) Aug 15, 2024 10:20pm

@enesozturk
Copy link

@zoruka Let's follow our PR template for the next ones 🙏🏽

@enesozturk
Copy link

Oh sorry this is web-examples repo lol, ignore please. But maybe we could bring template to this repo as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants