Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cleanup/error handling #17

Open
schmiddy opened this issue Oct 28, 2012 · 0 comments
Open

Improve cleanup/error handling #17

schmiddy opened this issue Oct 28, 2012 · 0 comments
Milestone

Comments

@schmiddy
Copy link
Member

A few gripes with our current error handling:

  • pgut_atexit_push() is called relatively late (after step 1 is complete), which is probably OK with current git master, but is a bit dodgy for the concurrent-ddl-guard changes
  • Instead of calling ROLLBACK unconditionally, we should use pgut_rollback() which checks PQtransactionStatus(conn)
  • Instead of using printf() plus exit() for reporting fatal error messages, an elog or ereport ... ERROR seems more appropriate
  • Errors encountered in reorg_one_table(), e.g. for conflicted triggers, shouldn't be treated as fatal -- pg_reorg might be operating on a whole database, and should be able to continue processing other tables
@schmiddy schmiddy reopened this Nov 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant