Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-functional login subcommand on emp #1166

Open
aengelas opened this issue Nov 13, 2020 · 2 comments
Open

Remove non-functional login subcommand on emp #1166

aengelas opened this issue Nov 13, 2020 · 2 comments

Comments

@aengelas
Copy link
Contributor

Now that GitHub has shut down their legacy access for apps, users need to upgrade to a version of empire that supports weblogin, and we should probably remove the login functionality and rename the weblogin behavior to be the default (leaving weblogin as an alias for continuity?).
@aengelas
Copy link
Contributor Author

@jherico It looks like the weblogin functionality touches the empire server as well as the emp CLI?

@jherico
Copy link
Contributor

jherico commented Apr 26, 2021

@aengelas I think the problem is that it's possible to have different authentication backends besides Github where the existing login command still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jherico @aengelas