Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming AWS change in ARN format breaks emp ps #1156

Open
tyrken opened this issue Sep 3, 2020 · 0 comments
Open

Upcoming AWS change in ARN format breaks emp ps #1156

tyrken opened this issue Sep 3, 2020 · 0 comments

Comments

@tyrken
Copy link
Contributor

tyrken commented Sep 3, 2020

AWS have long had an option to use a new format for ECS arns for services, tasks and container-instances, see https://aws.amazon.com/blogs/compute/migrating-your-amazon-ecs-deployment-to-the-new-arn-and-resource-id-format-2/
What's new is that from October 2020 these options default to on for new accounts, and April 2021 they become mandatory for all accounts. So from that latter date our existing empire controllers will see a mix of old & newer formats.

I've tested this by making a new account with the options turned on and it mostly works. The only fault I've found so far is that emp ps breaks, giving a "invalid ARN resource" error, likely from

empire/pkg/arn/arn.go

Lines 63 to 77 in 7ab6b86

// SplitResource splits the Resource section of an ARN into its type and id
// components.
func SplitResource(r string) (resource, id string, err error) {
p := strings.Split(r, "/")
if len(p) != 2 {
err = ErrInvalidResource
return
}
resource = p[0]
id = p[1]
return
}

Anybody else come across this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant