Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Portuguese from Portugal translation #135

Open
jfreves opened this issue May 21, 2024 · 2 comments
Open

Wrong Portuguese from Portugal translation #135

jfreves opened this issue May 21, 2024 · 2 comments

Comments

@jfreves
Copy link

jfreves commented May 21, 2024

When setting up the language with pt (Portuguese from Portugal) the translation for moonrise and moonset is not correct, it is using dawn and dusk translations which are not correct.
image

"dawn": "Amanhecer",
"dusk": "Anoitecer",
"elevation": "Elevação",
"moonrise": "Anoitecer",
"moonset": "Amanhecer",

It seems that was already a PR with the correct translation but was dismissed for some reason.

It would made more sense to remove pt-BR translation and use its values simply as pt since there's no differences between these.

@ThomDietrich
Copy link

ThomDietrich commented May 21, 2024

Hey @jfreves, not quite the whole story. Please see #100
CC @ViPeR5000
Pleae open a PR with your fix to all the above.

@jfreves
Copy link
Author

jfreves commented May 21, 2024

Hey @jfreves, not quite the whole story. Please see #100 CC @ViPeR5000 Pleae open a PR with your fix to all the above.

I noticed that PR but don't understand the reason for it since the one from FragMenthor was correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants