Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse requirements with environment markers #121

Open
gforcada opened this issue Jun 26, 2023 · 0 comments
Open

Parse requirements with environment markers #121

gforcada opened this issue Jun 26, 2023 · 0 comments

Comments

@gforcada
Copy link
Collaborator

gforcada commented Jun 26, 2023

For example on Products.MimetypesRegistry we have:

'pywin32 ; platform_system=="Windows"',

Which actually provides different imports, namely win32api and win32con.

You can do a mapping for them:

'pywin32' = ['win32api', 'win32con']

But z3c.depenedencychecker still fails with it 😓

When you remove the environment marker though, then it all works 🎉

Whenever we are parsing the requirements of a given distribution we are reading the file and being happy with it. We should parse those lines and remove the environment markers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant