Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong xo config resolved #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Nov 20, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This PR fixes a lot of CI errors which is caused by xojs/xo#741

@JounQin JounQin requested a review from wooorm November 20, 2023 19:55
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Nov 20, 2023
package.json Outdated Show resolved Hide resolved
@JounQin
Copy link
Member Author

JounQin commented Nov 21, 2023

@wooorm OK, why xo: false is set? That's the root cause of the CI test errors. Please help to confirm the desired behavior so that I can update this PR accordingly.

@wooorm
Copy link
Member

wooorm commented Nov 21, 2023

Because previously xo used xo: false for nested packages, to continue looking for a parent package.json.
Omitting xo: false, previously, resulted in the defaults being applied.
Which is exactly what xo is now doing when xo: false is used.

@wooorm
Copy link
Member

wooorm commented Nov 21, 2023

Note: updating this project is complex, you don’t have to do the work, I can do it too!

@JounQin
Copy link
Member Author

JounQin commented Nov 21, 2023

Because previously xo used xo: false for nested packages, to continue looking for a parent package.json. Omitting xo: false, previously, resulted in the defaults being applied. Which is exactly what xo is now doing when xo: false is used.

So this seems a new bug which I described at xojs/xo#741 (comment), I'll change the fix then.

@JounQin
Copy link
Member Author

JounQin commented Nov 21, 2023

Note: updating this project is complex, you don’t have to do the work, I can do it too!

No worry, I just found bugs and want to fix them, no matter it's in xo or rehype-github, just interesting.

@JounQin
Copy link
Member Author

JounQin commented Nov 21, 2023

image

The only left thing is test-coverage, I think I'll leave it to you and you can fix the test-coverage based on this PR. @wooorm

@JounQin
Copy link
Member Author

JounQin commented Nov 21, 2023

It's also fine if you want to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤞 phase/open Post is being triaged manually
Development

Successfully merging this pull request may close these issues.

2 participants