You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@julia-wrobel any recollection of 35206e8? Seems to have removed all the tests for vis.fgam. vis.fgam currenty seems to fail for any model.
Something to do with those deprecation warnings? Guessing that deprecation work won't happen? @huangracer doesn't seem too active on GitHub anymore and those were added by him in 2015.
predict.fgam also looks for a component of the fitted fgam object named fgam, which seems to no longer exist.
Potentially vis.fgam and predict.fgam could be removed if they're too difficult to patch. Dangerous to keep functions around with no tests better to just remove them or have tests that don't run on CRAN.
Got a question about plotting af terms with Qtransform=TRUE. Came across #47. Seems to work with plot.prf but not vis.pfr or vis.fgam.
The text was updated successfully, but these errors were encountered:
@julia-wrobel any recollection of 35206e8? Seems to have removed all the tests for
vis.fgam.vis.fgamcurrenty seems to fail for any model.Something to do with those deprecation warnings? Guessing that deprecation work won't happen? @huangracer doesn't seem too active on GitHub anymore and those were added by him in 2015.
predict.fgamalso looks for a component of the fittedfgamobject namedfgam, which seems to no longer exist.Potentially
vis.fgamandpredict.fgamcould be removed if they're too difficult to patch. Dangerous to keep functions around with no tests better to just remove them or have tests that don't run on CRAN.Got a question about plotting
afterms withQtransform=TRUE. Came across #47. Seems to work withplot.prfbut notvis.pfrorvis.fgam.The text was updated successfully, but these errors were encountered: