Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Result namespace Source Map does not account for multiple files #42

Closed
zdne opened this issue Aug 19, 2015 · 8 comments
Closed

Parse Result namespace Source Map does not account for multiple files #42

zdne opened this issue Aug 19, 2015 · 8 comments

Comments

@zdne
Copy link
Member

zdne commented Aug 19, 2015

In the prism of solving apiaryio/api-blueprint#8 the source map should be not only be capable of holding the location within a file but also be able to identify the file.

This is currently not the case and should we need it in a future the Source Map element would have to be changed in a backward incompatible way.

@smizell
Copy link
Contributor

smizell commented Aug 20, 2015

@zdne This makes sense to me.

@pksunkara
Copy link
Contributor

RFC0006 made sure the current source map refract is future-proof for adding multiple file support.

@smizell
Copy link
Contributor

smizell commented Sep 24, 2015

@smizell smizell closed this as completed Sep 24, 2015
@pksunkara
Copy link
Contributor

I don't think we should close this since we didn't add multiple file support yet. We just made the existing structure future proof.

@smizell smizell reopened this Sep 24, 2015
@smizell
Copy link
Contributor

smizell commented Sep 24, 2015

Wish granted :)

@pksunkara
Copy link
Contributor

@smizell Should we move this to api-elements repo?

@smizell
Copy link
Contributor

smizell commented May 20, 2016

Move to API Elements.

@kylef
Copy link
Member

kylef commented Jul 7, 2017

-> apiaryio/api-elements#26

@kylef kylef closed this as completed Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants