Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include wiki diffs in hasCode #88

Open
fregante opened this issue Aug 6, 2021 · 3 comments
Open

Include wiki diffs in hasCode #88

fregante opened this issue Aug 6, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@fregante
Copy link
Member

fregante commented Aug 6, 2021

Example:

https://github.com/pixiebrix/pixiebrix-extension/wiki/Web-Extensions-behaviors/_compare/664a8f7^...664a8f7

There might be more URLs.

@fregante fregante added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 6, 2021
@cheap-glitch
Copy link
Contributor

Source files diffs should probably be included too, e.g.:

https://togithub.com/fregante/github-url-detection/edit/main/index.ts

The thing is, there's not really any "code elements" on the page until you make an edit and click on the "Preview" tab.

@fregante
Copy link
Member Author

Nah that's a bit much. To target previews we have to add specific listeners and I don't really want to add selection-observer there too 😬

@cheap-glitch
Copy link
Contributor

Nah that's a bit much. To target previews we have to add specific listeners and I don't really want to add selection-observer there too 😬

It could still be useful to include those URLs for some CSS-only features, e.g. hide-diff-signs. But I guess this should be done in the feature-specific code then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Development

No branches or pull requests

2 participants