Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s backend domain envvar support #165

Open
pl4nty opened this issue Sep 14, 2021 · 3 comments
Open

k8s backend domain envvar support #165

pl4nty opened this issue Sep 14, 2021 · 3 comments
Labels
component/k8s k8s backend kind/enhancement New feature or request

Comments

@pl4nty
Copy link
Contributor

pl4nty commented Sep 14, 2021

To support dynamic environments (eg staging), the k8s backend could support environment variables for at least the domain (eg RCDS_K8S_DOMAIN). A similar feature is implemented in the rCTF backend for its URL and token.

@pl4nty
Copy link
Contributor Author

pl4nty commented Sep 14, 2021

I can make a PR this weekend if approved - just want to make sure this feature doesn't clash with any planned changes to the config management architecture (#113).

@ethanwu10
Copy link
Member

Unfortunately we don't have the resources right now to implement a lot of the changes that we think rCDS needs, so most of the todo list in #113 is shelved for the time being. I'd be happy to take PRs for this, your proposal looks good to me. I suppose in addition to the domain, the kube context name should also be settable via env var too.

@ethanwu10 ethanwu10 added the kind/enhancement New feature or request label Sep 15, 2021
@pl4nty
Copy link
Contributor Author

pl4nty commented Sep 19, 2021

No worries. I got sidetracked a bit this weekend, but I'll send through a few PRs now that my prod environment is mostly built. Can't commit to anything major unfortunately.

@ethanwu10 ethanwu10 added the component/k8s k8s backend label Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/k8s k8s backend kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants