Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis::CommandError < RedisClient::CommandError #1206

Closed
pboling opened this issue Jul 13, 2023 · 2 comments
Closed

Redis::CommandError < RedisClient::CommandError #1206

pboling opened this issue Jul 13, 2023 · 2 comments

Comments

@pboling
Copy link

pboling commented Jul 13, 2023 •
edited
Loading

Why not this?

It seems like it would be helpful for libraries initially built on top of redis that later switch to redis-client for fine tuning (e.g. seems this is what happened with redlock).

For more context: leandromoreira/redlock-rb#135
@byroot
Copy link
Collaborator

byroot commented Jul 13, 2023

Because Redis::CommandError already has a superclass.

@byroot byroot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2023
@pboling
Copy link
Author

pboling commented Jul 14, 2023

Fair. 👯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pboling @byroot