fixing broken Pydantic v1 regression #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #646 - can validate by changing:
to
in the pyproject.toml and running:
poetry lock poetry install make testIn pydantic v1.x, there are some broken tests which are a result of some of the tests requiring pydantic 2.x types.
I have not added any additional regression testing for it given that pydantic 1.x, it seems to be moving out of support and I don't have a solid way of automating testing of it (poetry doesn't seem to support me specifying which pydantic version to install?), if anyone from the community or @sav-norem or @bsbodden have any good ideas, all ears.