flush-commands-docs #872
Open
flush-commands-docs #872
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oranagra
reviewed
Nov 13, 2024
| @@ -66,6 +66,7 @@ It is possible to use one of the following modifiers to dictate the flushing mod | |||
|
|
|||
| * An asynchronous `FLUSHALL` command only deletes keys that were present at the time the command was invoked. Keys created during an asynchronous flush will be unaffected. | |||
| * This command does not delete functions. | |||
| * When using Redis Cluster, this command is identical to `FLUSHDB` since a Redis Cluster supports only database zero. | |||
There was a problem hiding this comment.
that's actually incorrect.
FLUSHALL has some side effects that FLUSHDB does not, and currently even on a single db deployment these still hold.
for instance, FLUSHALL saves an empty RDB file and resets the dirty counter.
There was a problem hiding this comment.
i'm not certain if we want to fix it and change the behavior of FLUSHDB on a single-db deployments, or document that. but for sure we should avoid stating wrong facts. 😜
There was a problem hiding this comment.
We definitely want to document the current behavior, including all side effects. Otherwise, people would have false assumptions. Oran, please suggest an edit.
There was a problem hiding this comment.
something like that:?
Other than emptying all databases (similar to FLUSHDB), this command can also clear the persistence RDB file,
it aborts any snapshot that's in progress, and if the `save` config is enabled, it saves an empty RDB file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added notes:
FLUSHDBandFLUSHALLare identical on a Redis cluster.(following https://redis.slack.com/archives/CLZCLHWQ0/p1731468610504539)