Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 1.33.0. #3728

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

rgrunber
Copy link
Member

  • Adjust project compliance to reflect drop of pre-1.8 support in JDT

Due to eclipse-jdt/eclipse.jdt.core#2551 (in the I-builds of late July).

Copy link
Collaborator

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just one question about drop support for pre-1.8. Should we mention in the changelog that this version no longer supports Java versions (< 1.8) earlier than 1.8?

@rgrunber
Copy link
Member Author

rgrunber commented Aug 1, 2024

LGTM.

Just one question about drop support for pre-1.8. Should we mention in the changelog that this version no longer supports Java versions (< 1.8) earlier than 1.8?

Sounds reasonable. I'll add an entry mentioning in both JDT-LS & vscode-java .

@testforstephen , on second thought, if I make this an entry, what would be the category. It's definitely not an enhancement / bugfix :\ Could I just list it as "dependencies" ?

- Adjust project compliance to reflect drop of pre-1.8 support in JDT

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber rgrunber merged commit ba61599 into redhat-developer:master Aug 1, 2024
2 checks passed
@rgrunber rgrunber deleted the cl-1.33.0 branch August 1, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants